[configuration] Fix option deletion issue. #9121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing eslint |
|
@kongtiaowang can you test this? |
kongtiaowang
added
the
Passed Manual Tests
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
The handler in
configuration/jsx/configuration_helper.jswas not properly taken the option to be deleted since the fields not always have necessary to be of SELECT type (they could be also text for example).Now it should take the appropriate option to be deleted.
Testing instructions (if applicable)
Please go to configuration module
MainMenu->Admin->ConfigurationGo to one of the "Tabs" that allow multiselect (for example
MINC to BIDS Converter Tool Options)Create some options and try to delete they after
Test Confirming and Canceling
The field should be deleted under confirmation.
Please test also with "other data type" (for example instruments in Study tab)
Link(s) to related issue(s)